[refpolicy] [PATCH] Add Debian location for rtkit-daemon daemon

Christopher J. PeBenito cpebenito at tresys.com
Mon Sep 17 10:17:17 CDT 2012


On 09/13/12 12:06, Dominick Grift wrote:
> 
> 
> On Thu, 2012-09-13 at 11:56 -0400, Daniel J Walsh wrote:
>> On 09/13/2012 08:19 AM, Dominick Grift wrote:
>>>
>>>
>>> On Thu, 2012-09-13 at 00:14 +0200, Laurent Bigonville wrote:
>>>> From: Laurent Bigonville <bigon at bigon.be>
>>>>
>>>> --- rtkit.fc |    4 ++++ 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/rtkit.fc b/rtkit.fc index 52c441e..fd82305 100644 ---
>>>> a/rtkit.fc +++ b/rtkit.fc @@ -1 +1,5 @@ /usr/libexec/rtkit-daemon	--
>>>> gen_context(system_u:object_r:rtkit_daemon_exec_t,s0) + 
>>>> +ifdef(`distro_debian',` +/usr/lib/rtkit/rtkit-daemon	--
>>>> gen_context(system_u:object_r:rtkit_daemon_exec_t,s0) +')
>>>
>>> This was merged. Thanks
>>>
>>>
>> I have never been a big fan of the ifdef(DISTRO) stuff in the fc files. Why is
>> it necessary hear?  Only reason for this would be if another distro had a file
>> here named /usr/lib/rtkit/rtkit-daemon that they wanted to label differently.
>>  Lets not flood the fc files with these macros.  I could definitely see Fedora
>> moving to this location.  Driven by systemd.
> 
> I agree, but until we get consensus cross the board regarding this issue
> i don't see any reason to reject these patches.
> 
> removing the ifdef wrappers is trivial so as soon as we can all agree
> ill remove them.
> 
> So i would like to hear opinions of at least pebenito. bigon and swift
> about this as well (which i cc'd)
 
We can always remove the ifdef if Fedora uses that path.  But in this case, the fc seems odd to me; why would you put a service's executable in /usr/lib (even as a subdir)?

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com


More information about the refpolicy mailing list